Skip to content

Drop further code for Debian 6 and Ubuntu 10 #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2021
Merged

Drop further code for Debian 6 and Ubuntu 10 #1307

merged 1 commit into from
Oct 4, 2021

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Sep 30, 2021

8cc1660 dropped support for these OS versions, but left this code in. This greatly simplifies the code.

@ekohl
Drop further code for Debian 6 and Ubuntu 10
da9f338 
8cc1660 dropped support for these OS
versions, but left this code in. This greatly simplifies the code.

Fixes: 8cc1660
@ekohl ekohl requested a review from a team as a code owner September 30, 2021 12:00
@puppet-community-rangefinder
Copy link

postgresql::params is a class

that may have no external impact to Forge modules.

This module is declared in 70 of 578 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@ekohl ekohl mentioned this pull request Sep 30, 2021
Merged
bastelfreak
bastelfreak reviewed Sep 30, 2021
View reviewed changes
Copy link
Collaborator

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but since the recent changes for not adding backwards-incompatible labels for OS removals in metadata.json I don't know if this is considered backwards-incompatible or not.

@ekohl
Copy link
Collaborator Author

ekohl commented Sep 30, 2021

Considering #1290 wasn't backwards-incompatible, I'd think this isn't either.

@david22swan
Copy link
Member

david22swan commented Oct 4, 2021 •
edited
Loading

@ekohl Everything look's good and I'm happy to merge. Since support of the OS's was officially dropped prior to a previous major release I wouldn't count this as backwards incompatible.
Thank's for the great work :)

@david22swan david22swan merged commit fe44cec into puppetlabs:main Oct 4, 2021
@ekohl ekohl deleted the drop-debian-6-ubuntu-10 branch October 4, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekohl @david22swan @bastelfreak